bitcoin: 30.1 -> 29.1 #477611
Closed
bitcoin: 30.1 -> 29.1 #477611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9ccd15. Note that willcl-ark.gpg is still in the list of checked signers, see the discussion in NixOS#476387
This reverts commit b8758c3.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
roconnor
approved these changes
Jan 7, 2026
Contributor
roconnor
left a comment
roconnor
left a comment
There was a problem hiding this comment.
I reviewed the diff but didn't test it.
nixpkgs-ci
bot
added
12.approvals: 1
Contributor
|
While bitcoin-core/bitcoincore.org#1213 is still a draft, I think it's a priority of the project to get v30.2 released. I wonder if it's worth downgrading now and then upgrading to v30.2 ~next week instead of just upgrading to v30.2 once it's released? |
Member
|
+1 to wait for 30.2 |
Contributor
|
My view is that the package is currently broken; cached binaries could cause users to lose funds; and we don't actually know when 30.2 will be available. |
Contributor
|
Binaries for v30.2 are now available: https://bitcoincore.org/bin/bitcoin-core-30.2/. |
0xB10C
added a commit
to 0xB10C/nixpkgs
that referenced
this pull request
Jan 10, 2026
This includes a fix for https://groups.google.com/g/bitcoindev/c/QsC_FWPNGr4/m/t6MSDT6pBQAJ I've disabled the signers that didn't sign this release before the binaries were published. Only the following signers signed in time: - Sjors - guggero - pinheadmz - fanquake - 0xb10c - achow101 - Emzy - hebasto This closes NixOS#477611 as we don't need to downgrade anymore.
Contributor
|
Opened #478769 for v30.2 |
Member
Closing |
a-kenji
pushed a commit
to a-kenji/nixpkgs
that referenced
this pull request
Jan 14, 2026
This includes a fix for https://groups.google.com/g/bitcoindev/c/QsC_FWPNGr4/m/t6MSDT6pBQAJ I've disabled the signers that didn't sign this release before the binaries were published. Only the following signers signed in time: - Sjors - guggero - pinheadmz - fanquake - 0xb10c - achow101 - Emzy - hebasto This closes NixOS#477611 as we don't need to downgrade anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://groups.google.com/g/bitcoindev/c/QsC_FWPNGr4/m/t6MSDT6pBQAJ
This undoes #476387 and #451606
Bitcoin 30.1 and 30.0 are affected by a rare bug in the wallet compound, which may result in a loss of funds. Rolling back to safety.
Note that code signer willcl-ark which we added in #476387 is still in the list. He has signed 29.1, so we should keep him.
I propose to use 29.1 and not update to 29.2, because Ava Chow mentioned in the mailing list, that version 30 will be fixed in 30.2 and we can update right to it.
Analyzing release notes for 30.0 and 30.1 I haven't found any downgrade risks. The only caveat is coinstat index rebuilding, but they have accounted for it in the release notes.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.